simcop2387/docker-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity

generate.pl: Use 3-arg open()

Browse source 
Heed perlcritic/PBP
This commit is contained in:
Zak B. Elep 2017-08-11 17:24:44 +08:00
parent fcd5c61de4
commit d6371f3fdf
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
generate.pl
View file

@ -26,7 +26,7 @@ EOF
} }
my $yaml = do { my $yaml = do {
open my $fh, "Releases.yaml" or die "Couldn't open releases"; open my $fh, "<", "Releases.yaml" or die "Couldn't open releases";
local $/; local $/;
Load <$fh>; Load <$fh>;
}; };
@ -105,7 +105,7 @@ for my $release (@{$yaml->{releases}}) {
# Set up the generated DevelPatchPerl.patch # Set up the generated DevelPatchPerl.patch
{ {
open(my $fh, ">$dir/DevelPatchPerl.patch"); open my $fh, ">", "$dir/DevelPatchPerl.patch";
print $fh $patch; print $fh $patch;
} }
@ -117,7 +117,7 @@ for my $release (@{$yaml->{releases}}) {
die "test_parallel was provided for $release->{version} but is invalid; should be 'yes' or 'no'\n"; die "test_parallel was provided for $release->{version} but is invalid; should be 'yes' or 'no'\n";
} }
open my $dockerfile, ">$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing"; open my $dockerfile, ">", "$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing";
print $dockerfile $output; print $dockerfile $output;
close $dockerfile; close $dockerfile;
} }