From d6371f3fdfddfba610c1f5edd908b13d00d492c4 Mon Sep 17 00:00:00 2001 From: "Zak B. Elep" Date: Fri, 11 Aug 2017 17:24:44 +0800 Subject: [PATCH] generate.pl: Use 3-arg open() Heed perlcritic/PBP --- generate.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/generate.pl b/generate.pl index 9b6d6bb..79d8814 100755 --- a/generate.pl +++ b/generate.pl @@ -26,7 +26,7 @@ EOF } my $yaml = do { - open my $fh, "Releases.yaml" or die "Couldn't open releases"; + open my $fh, "<", "Releases.yaml" or die "Couldn't open releases"; local $/; Load <$fh>; }; @@ -105,7 +105,7 @@ for my $release (@{$yaml->{releases}}) { # Set up the generated DevelPatchPerl.patch { - open(my $fh, ">$dir/DevelPatchPerl.patch"); + open my $fh, ">", "$dir/DevelPatchPerl.patch"; print $fh $patch; } @@ -117,7 +117,7 @@ for my $release (@{$yaml->{releases}}) { die "test_parallel was provided for $release->{version} but is invalid; should be 'yes' or 'no'\n"; } - open my $dockerfile, ">$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing"; + open my $dockerfile, ">", "$dir/Dockerfile" or die "Couldn't open $dir/Dockerfile for writing"; print $dockerfile $output; close $dockerfile; }