simcop2387/nginx-proxy-manager-infra

Watch

Fork 0

Update alpine Docker tag to v3.24 #2

Merged

simcop2387 merged 1 commit from renovate/alpine-3.x into main

2026-08-09 17:07:29 -04:00

renovatebot commented

2026-08-08 17:55:29 -04:00

Collaborator

This PR contains the following updates:

Package	Type	Update	Change
alpine (source)	stage	minor	`3.16` → `3.24`

⚠️ Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Configuration

📅 Schedule: (UTC)

Branch creation
- At any time (no schedule defined)
Automerge
- At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [alpine](https://hub.docker.com/_/alpine) ([source](https://github.com/alpinelinux/docker-alpine)) | stage | minor | `3.16` → `3.24` | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/3) for more information. --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).

renovatebot added 1 commit

2026-08-08 17:55:29 -04:00

Update alpine Docker tag to v3.24

Hodor Review / review (pull_request) Successful in 6m30s

Details

Hodor Review / review-default (pull_request) Successful in 0s

Details

Hodor Review / review-1 (pull_request) Successful in 1m54s

Details

Hodor Review / review-security (pull_request) Successful in 0s

Details

7c9e8852ca

forgejo-actions commented

2026-08-08 18:23:24 -04:00

Issues Found

Important (P2)

[P2] Hardcoded python3.10 paths break on Alpine 3.24 (Dockerfile:77-81)
- The certbot build stage hardcodes /usr/lib/python3.10/site-packages in five find commands (lines 77-81). Alpine 3.16 shipped with Python 3.10, so these paths were correct. Alpine 3.24 ships with Python 3.13, so apk add python3 installs Python 3.13 and pip places certbot packages under python3.13/site-packages. The find commands targeting python3.10 will silently succeed (exit 0) on a non-existent path, causing all stripping and cleanup steps to be skipped. This results in a larger, unoptimized final image with unstripped .so files and leftover .h, .c, .exe, and tests artifacts.

Summary

Total issues: 0 critical, 1 important, 0 minor.

Overall Verdict

Status: Patch has blocking issues

Explanation: The Alpine 3.16 → 3.24 upgrade changes the default Python version from 3.10 to 3.13. The certbot build stage hardcodes python3.10 in its site-packages cleanup paths, causing those optimization steps to silently fail on the new base image. Using a wildcard pattern (python3*) would make the paths resilient to Python version changes.

Review generated by Hodor (model: openai/Qwen3.6-27B-single:medium)

Review Metrics — 4 turns, 4 tool calls, 6m 28s

Tokens: in 22.0K | fresh 10.2K | cache read 11.8K | out 2.3K (total 24.3K)

### Issues Found **Important (P2)** - **[P2] Hardcoded python3.10 paths break on Alpine 3.24** (`Dockerfile:77-81`) - The certbot build stage hardcodes `/usr/lib/python3.10/site-packages` in five `find` commands (lines 77-81). Alpine 3.16 shipped with Python 3.10, so these paths were correct. Alpine 3.24 ships with Python 3.13, so `apk add python3` installs Python 3.13 and pip places certbot packages under `python3.13/site-packages`. The `find` commands targeting `python3.10` will silently succeed (exit 0) on a non-existent path, causing all stripping and cleanup steps to be skipped. This results in a larger, unoptimized final image with unstripped `.so` files and leftover `.h`, `.c`, `.exe`, and `tests` artifacts. ### Summary Total issues: 0 critical, 1 important, 0 minor. ### Overall Verdict **Status**: Patch has blocking issues **Explanation**: The Alpine 3.16 → 3.24 upgrade changes the default Python version from 3.10 to 3.13. The certbot build stage hardcodes `python3.10` in its site-packages cleanup paths, causing those optimization steps to silently fail on the new base image. Using a wildcard pattern (`python3*`) would make the paths resilient to Python version changes. --- Review generated by Hodor (model: `openai/Qwen3.6-27B-single:medium`) **Review Metrics** — 4 turns, 4 tool calls, 6m 28s - Tokens: in `22.0K` | fresh `10.2K` | cache read `11.8K` | out `2.3K` (total `24.3K`)

forgejo-actions commented

2026-08-08 18:25:19 -04:00

Issues Found

No issues found.

Summary

Total issues: 0 critical, 0 important, 0 minor.

Overall Verdict

Status: Patch is correct

Explanation: There are no changes since the last Hodor review (commit 7c9e885). The incremental delta is empty, so no new findings are applicable. The previous review already identified the hardcoded python3.10 paths issue, which remains unchanged in this delta.

Review generated by Hodor (model: openai/Qwen3.6-27B-single:medium)

Review Metrics — 4 turns, 4 tool calls, 1m 51s

Tokens: in 19.7K | fresh 4.9K | cache read 14.8K | out 419 (total 20.1K)

### Issues Found No issues found. ### Summary Total issues: 0 critical, 0 important, 0 minor. ### Overall Verdict **Status**: Patch is correct **Explanation**: There are no changes since the last Hodor review (commit 7c9e885). The incremental delta is empty, so no new findings are applicable. The previous review already identified the hardcoded python3.10 paths issue, which remains unchanged in this delta. --- Review generated by Hodor (model: `openai/Qwen3.6-27B-single:medium`) **Review Metrics** — 4 turns, 4 tool calls, 1m 51s - Tokens: in `19.7K` | fresh `4.9K` | cache read `14.8K` | out `419` (total `20.1K`)