From a83a495af1b1eee9c0d3987266f98a6a86d89ad2 Mon Sep 17 00:00:00 2001 From: Max Maischein Date: Sat, 12 Sep 2020 22:35:49 +0200 Subject: [PATCH] Note an optimization, for later --- dbdimp_tokenizer.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dbdimp_tokenizer.inc b/dbdimp_tokenizer.inc index c91a8d5..712c50c 100644 --- a/dbdimp_tokenizer.inc +++ b/dbdimp_tokenizer.inc @@ -424,8 +424,8 @@ static int perl_fts5_tokenizer_Tokenize( dTHX; dSP; - /* The implicit assumption here is that our callback will only be - * invoked from a stack frame below this frame! + /* newSVpvn() will create a copy of this buffer, but ideally we would + * directly write into the PV part of that copied buffer instead */ perl_cb_ctx ctx; SV* ctxP;