From 2fa57ee8fa1bec4ced80d8c7949e4685e56f7055 Mon Sep 17 00:00:00 2001
From: Kenichi Ishigaki <ishigaki@cpan.org>
Date: Sun, 18 Oct 2009 13:37:11 +0000
Subject: [PATCH] DBD::SQLite: removed undocumented and useless reset method
 from a statement handle

---
 Changes   | 6 ++++++
 SQLite.xs | 8 --------
 dbdimp.c  | 8 --------
 dbdimp.h  | 1 -
 4 files changed, 6 insertions(+), 17 deletions(-)

diff --git a/Changes b/Changes
index 50c0598..b9d1476 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,12 @@
 Changes for Perl extension DBD-SQLite
 
 1.26_06 (not released yet)
+    *** CHANGES THAT MAY POSSIBLY BREAK YOUR OLD APPLICATIONS ***
+    - Removed undocumented (and most probably unused) reset method
+      from a statement handle. This violated the DBI spec (driver-
+      specific methods must have names that begin with the registered
+      prefix) and was not useful as it didn't return any result.
+      (ISHIGAKI)
 
 1.26_05 Thu 15 Oct 2009
     - Updated to SQLite 3.6.19 (ISHIGAKI)
diff --git a/SQLite.xs b/SQLite.xs
index c009e88..7e5c49c 100644
--- a/SQLite.xs
+++ b/SQLite.xs
@@ -199,14 +199,6 @@ MODULE = DBD::SQLite          PACKAGE = DBD::SQLite::st
 
 PROTOTYPES: DISABLE
 
-void
-reset(sth)
-    SV *sth
-    CODE:
-    {
-        sqlite_st_reset(aTHX_ sth);
-    }
-
 MODULE = DBD::SQLite          PACKAGE = DBD::SQLite
 
 # a couple of constants exported from sqlite3.h
diff --git a/dbdimp.c b/dbdimp.c
index 465837f..6ebb0e4 100644
--- a/dbdimp.c
+++ b/dbdimp.c
@@ -317,14 +317,6 @@ sqlite_st_prepare(SV *sth, imp_sth_t *imp_sth, char *statement, SV *attribs)
     return TRUE;
 }
 
-void
-sqlite_st_reset (pTHX_ SV *sth)
-{
-    D_imp_sth(sth);
-    if (DBIc_IMPSET(imp_sth))
-        sqlite3_reset(imp_sth->stmt);
-}
-
 int
 sqlite_st_execute (SV *sth, imp_sth_t *imp_sth)
 {
diff --git a/dbdimp.h b/dbdimp.h
index d0555ac..90fe0a3 100644
--- a/dbdimp.h
+++ b/dbdimp.h
@@ -84,7 +84,6 @@ int sqlite_db_enable_load_extension(pTHX_ SV *dbh, int onoff);
 int sqlite_db_create_aggregate(pTHX_ SV *dbh, const char *name, int argc, SV *aggr );
 int sqlite_db_create_collation(pTHX_ SV *dbh, const char *name, SV *func);
 int sqlite_db_progress_handler(pTHX_ SV *dbh, int n_opcodes, SV *handler);
-void sqlite_st_reset(pTHX_ SV *sth );
 int sqlite_bind_col( SV *sth, imp_sth_t *imp_sth, SV *col, SV *ref, IV sql_type, SV *attribs );
 int sqlite_db_busy_timeout (pTHX_ SV *dbh, int timeout );
 int sqlite_db_backup_from_file(pTHX_ SV *dbh, char *filename);